Broken link, strange warning and missing text #1244

CLOSED
Submitted 6 months ago

On section 1, the link leads to a page with a .gif showing the snippet at work, but the snippet’s link itself is broken. I could find similar snippets here: https://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/examples/org.eclipse.jface.snippets/Eclipse%20JFace%20Snippets/org/eclipse/jface/snippets/notifications

Section 4.1 has a warning saying that "You will get a temporary compile error once you get this class because it uses the TodoWizard class which you create in the next step." But the class does not use the TodoWizard class. Is the code missing something or is the warning unnecessary?

In the end of section 4.3.1 there’s a warning that states that "you may get a new empty in the table". I believe it was meant to read "you may get a new empty line in the table"

Comments

  6 months ago

For the notification link, I think this link was fixed in the meantime. At least it works for me. Can you check? The code itself looks updated to me, I assume it will not compile about a 2023-09 target but only against a 2023-12 target.

  6 months ago

Is the code missing something or is the warning unnecessary?

Yes, this is unecessary. I removed it. Thanks

I believe it was meant to read "you may get a new empty line in the table"

Yes, fixed. Thanks

  6 months ago

Indeed, the link is working now.

Please login to write a comment.